Async Queue | using signed urls from objects so client can downlaod directly from object store #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectly from object store
MichaelRipa
reviewed
Nov 19, 2025
| if not verify_connection(host, port): | ||
| raise ConnectionError(f"Ray is not listening on {host}:{port}") | ||
|
|
||
| logger.info(f"Connecting to Ray at {cls.ray_url}...") |
Member
There was a problem hiding this comment.
This logging is useful for me, so I'm adding it back in
Member
|
I am trying to see whether I can assign a unique name for the logger for each task |
…s for signed url Bug fixed for hotswapping gating
MichaelRipa
reviewed
Nov 20, 2025
| logger.info("Connected to Ray") | ||
|
|
||
| @classmethod | ||
| def connected(cls) -> bool: |
Member
There was a problem hiding this comment.
Just so you are aware, I profiled this method and the added ray.get_actor() is significantly slower (high variance, but the slowest was just over 5 seconds).
Member
Author
There was a problem hiding this comment.
Which is fine because connected is only called if theres some critical error in the first place. I think its good to know youre truly connected if you can access the controller. Also makes it so if you run a test script right after brining it up, you wont get the error saying controller does not exist
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.