add missing docstrings to ray service #200 #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strings, optimized phrasing for pytest generation with clear inputs, outputs and examples
Member
|
Thanks! Again, #196 has some changes to the controller, so this likely will require some modifications (haven't looked yet). Will revisit later this week after it is merged in. I also plan on adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#200
docstrings are added to ray/deployments/controller/controller.py, including concise module-level docstring, function and class docstrings with optimized phrasing for pytest generation (clear inputs, outputs, examples).
If receiving good feedback, will expand to other files in ray service.