Skip to content

basic pytest setup for ray service, implementation of test_deployment.py ( #173) #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

basic pytest setup for ray service, implementation of test_deployment.py ( #173) #199

wants to merge 17 commits into from

Conversation

@artemisep
Copy link

@artemisep artemisep commented Nov 9, 2025

requirement:
#173
setup basic unit tests, with example ndif/src/services/ray/tests/unit/deployments/controller/cluster/test_deployment.py, instruction on how to run the test is added in ndif/src/services/ray/README.md.

@artemisep
check in initial pyproject.toml
0f5bd2b
@artemisep
check error-free pyproject.toml
6a40a02
@artemisep
mock ray package
5b2b3c9
@artemisep
fix external ray package not found error
41ad116
@artemisep
rename ndif internal ray package dir to ndif_ray
e4a5fa5
@artemisep
updates after renaming ray to ndif_ray
ac071d9
@artemisep
stub 'logging_loki' so internal logger module can import it
1c480e5
@artemisep
add stub for external ray library
a94a736
@artemisep
add stub for GlobalState in ray._private.state
e1873a6
@artemisep
add stubs for all external ray related components that are imported i…
bec3240 
…n internal ray service
@artemisep
create a small package to host shared types so not clash with stdlib
0da0a8d
@artemisep
change import to using the package name created to host the shared types
d665f3a
@artemisep
fix assertion error
e17785e
@artemisep
fix test code
8b12eed
@artemisep
minor mod
e6b5f06
@artemisep
update import statement after creating a small shared package ndif_sh…
9744299 
…ared to host types.py to fix relative import error, src/services/ray/tests/unit/deployments/controller/cluster/test_deployment.py 100% success
@artemisep
instruction for running pytest on a module or function
dfb8762
@artemisep artemisep changed the title PR for #173 basic pytest setup for ray service, implementation of test_deployment.py ( #173) Nov 10, 2025
@MichaelRipa MichaelRipa changed the base branch from main to dev November 10, 2025 20:14
@MichaelRipa
Copy link
Member

MichaelRipa commented Nov 10, 2025

Thanks for contributing! I'll review this in more depth later, but a few initial thoughts:

  • I switched the branch to dev. The MODEL_KEY is changing (see Typing enhancements #197), so a lot of your changes can be removed.
  • There's a lot of proposed changes here which aren't required. ndif_ray is a good example. I was thinking of just adding src/services/ray/src/tests/unit and just getting a few basic tests in.
  • We'll be getting rid of model deployments in Refactor deployments #196, so any of the tests which used deployments wouldn't be needed anymore (sorry!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemisep @MichaelRipa