Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
============================================
+ Coverage 82.43% 85.55% +3.12%
- Complexity 180 399 +219
============================================
Files 30 32 +2
Lines 723 1433 +710
Branches 85 274 +189
============================================
+ Hits 596 1226 +630
- Misses 90 98 +8
- Partials 37 109 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7496ea25d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ("(".equals(text)) { | ||
| depth++; | ||
| } else if (")".equals(text) && depth > 0) { | ||
| depth--; | ||
| } else if (",".equals(text) && depth == 0) { |
There was a problem hiding this comment.
countCallArguments only tracks nested ( / ) depth, so commas inside other nested constructs (for example new int[]{1, 2} or generic calls like map.<String, Integer>of()) are incorrectly counted as additional call arguments. In those cases the computed arity is too high, which makes resolveMethod pick the wrong overload or fail to create a link at all for valid method calls. The argument counter should ignore commas while inside at least angle-bracket, brace, and bracket nesting.
Useful? React with 👍 / 👎.
| private static boolean isEscaped(char[] chars, int index) { | ||
| return index > 0 && chars[index - 1] == '\\'; | ||
| } |
There was a problem hiding this comment.
isEscaped treats any quote preceded by a backslash as escaped, but Java escaping depends on whether the run of consecutive backslashes is odd. A literal ending with an even backslash run before the closing quote (for example a string ending in \\) is therefore misparsed as still-open, causing maskNonCode to remain in string/char mode and blank out subsequent code; this can suppress declarations and references for the rest of the file. The escape check should count consecutive backslashes and only treat odd counts as escaped.
Useful? React with 👍 / 👎.
|
1 participant
No description provided.