neuprint: Two fixes#124
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
Hi Stuart. Thanks, this looks good to me! If tests pass I'll merge right away. Do you need me to also release a new version to PyPI right away? |
Contributor
Author
Contributor
|
No need to do this right now. We can use the commit with fixes in our dependencies. Currently we are using 91671f1… |
Collaborator
|
Some tests failed but that's on me from an earlier commit. Merged, thanks for the contribution! Let me know if I can help with what you guys are up to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit allows the user to access single-resolution "legacy" precomputed meshes, but only if they pass
lod=None. Maybe you can suggest a friendlier implementation.The second commit concerns selecting a URL from the neuroglancer segmentation
source. In our neuroglancer links, we sometimes list multiple sources for segment properties, in which casesourceis a list-of-dict.These have gone through only minimal testing (by hand). Hopefully I haven't broken anything.