Migrated all models to use the UI Component Framework.

[itdependsnetworks]

firewall-screenshots.pdf

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
nautobot_firewall_models
details.py					21, 23, 27-28, 30
nautobot_firewall_models/models
nat_policy.py
security_policy.py
zone.py
nautobot_firewall_models/views
__init__.py
address.py
capirca_policy.py					42-44
nat_policy.py					71, 83
security_policy.py					77, 89
service.py
user.py
zone.py
Project Total

This report was generated by python-coverage-comment-action

[gsnider2195]

Thanks this looks good! Just found a couple of small issues.

[gsnider2195]

I think we should bump the minor version of firewall models with this change and update the compatibility matrix.

[gsnider2195]

Does this need to be object.policy_rules.exists? I made this change locally.

Before:

After:

[itdependsnetworks]

hmm, something is odd, I am seeing the inverse. With .exists it looks like your after.

[gsnider2195]

My "after" screenshot above was after changing it to use .exists.

[itdependsnetworks]

I'm confusing myself.. will re-look at it tonight.

[itdependsnetworks]

okay, looking at it, I presume the screenshot is where there is no rule in a set of policies, thus there should be no row. How it is, does currently meets my expectation.

• What this does: it a single template that normalizes policy_rules from policy
• What it does not do: Set a default of empty rule

[gsnider2195]

I don't think you can evaluate a model manager (Policy.policy_rules) as boolean.

>>> Policy.objects.all()
<RestrictedQuerySet [<Policy: Policy 1>, <Policy: Policy 2>, <Policy: Policy 3>]>
>>> type(Policy.objects.all()[0].policy_rules)
>>> django.db.models.fields.related_descriptors.create_forward_many_to_many_manager.<locals>.ManyRelatedManager
>>> Policy.objects.all()[0].policy_rules.all()
<RestrictedQuerySet [<PolicyRule: Policy Rule 1 - req1>]>
>>> Policy.objects.all()[1].policy_rules.all()
<RestrictedQuerySet [<PolicyRule: Policy Rule 1 - req1>, <PolicyRule: Policy Rule 2 - req2>]>
>>> Policy.objects.all()[2].policy_rules.all()
<RestrictedQuerySet []>
>>> bool(Policy.objects.all()[0].policy_rules)
True
>>> bool(Policy.objects.all()[1].policy_rules)
True
>>> bool(Policy.objects.all()[2].policy_rules)
True

{% if object.policy_rules %} will never evaluate to False so you'll never hit the else in this if/else. The screenshot I'm showing above is what it looks like when the else gets rendered correctly with nautobot_firewall_models/inc/policy_rules_tablerow.html

[itdependsnetworks]

Not going to worry about poetry.lock until 2.4.20 is published.