Skip to content

Conversation

@faysou
Copy link
Collaborator

@faysou faysou commented Oct 27, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Added return_as_dict argument to _read_feather for easier access to data by type

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Improvement (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou force-pushed the refine-stream-reading branch from 0297cd5 to bb3037e Compare October 27, 2025 15:32
@cjdsellers
Copy link
Member

Thanks @faysou, looks good

@cjdsellers cjdsellers merged commit 92dc103 into develop Oct 27, 2025
15 checks passed
@cjdsellers cjdsellers deleted the refine-stream-reading branch October 27, 2025 21:02
Antifrajz pushed a commit to Antifrajz/nautilus_trader that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants