Skip to content

Conversation

@faysou
Copy link
Collaborator

@faysou faysou commented Oct 11, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou force-pushed the makefile-compatibiilty branch from 1a8173b to bcade87 Compare October 11, 2025 20:06
@cjdsellers
Copy link
Member

Thanks @faysou, I'll make a couple of small tweaks post merge to retain original distclean behavior.

@cjdsellers cjdsellers merged commit 0aaa7df into develop Oct 11, 2025
17 checks passed
@cjdsellers cjdsellers deleted the makefile-compatibiilty branch October 11, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants