Refine setting of flags in Makefile #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
approved these changes
Oct 10, 2025
Member
cjdsellers
left a comment
cjdsellers
left a comment
There was a problem hiding this comment.
Thanks @faysou, good refinements.
I'll fix those two small things on develop branch.
| $Q uv sync --active --all-groups --all-extras --verbose | ||
|
|
||
| .PHONY: install-debug | ||
| install: BUILD_MODE=debug |
Member
There was a problem hiding this comment.
This needs to be install-debug
| .PHONY: build-wheel | ||
| build-wheel: BUILD_MODE=release | ||
| build-wheel: #-- Build wheel distribution in release mode | ||
| BUILD_MODE=release uv build --wheel |
Member
There was a problem hiding this comment.
This could be removed now as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
CONTRIBUTING.mdand followed the established practicesSummary
It's better to set env variables using the make syntax so it works on windows as well.
Related Issues/PRs
Type of change
Breaking change details (if applicable)
Documentation
docs/developer_guide/docs.md)Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Ensure new or changed logic is covered by tests.