Remove partial bars #3020
Merged
Remove partial bars #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I agree this is a nice simplification. It removes an undocumented feature that’s no longer needed. We now have better options for generating historical bars directly from trades and continuing with internal aggregation, instead of starting from externally formed bars plus a partial and then switching back to internal aggregation. |
cjdsellers
added a commit
that referenced
this pull request
Oct 3, 2025
- Filter incomplete bars using timestamp check in Binance and dYdX - Fix dYdX regression from PR #3020 that included partial bars - Clean up partial bar remnants (docs, stubs, comments) - Add breaking change entry to `RELEASES.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
CONTRIBUTING.mdand followed the established practicesSummary
Partial bars add complexity to the code and were used nowhere correctly in the code.
Related Issues/PRs
Type of change
Breaking change details (if applicable)
Documentation
docs/developer_guide/docs.md)Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Ensure new or changed logic is covered by tests.