Skip to content

Conversation

@faysou
Copy link
Collaborator

@faysou faysou commented Sep 24, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

Tested it works with a live node and IB

@cjdsellers cjdsellers changed the title Implement generate_fill_reports for IB adapter Implement Interactive Brokers generate_fill_reports Sep 24, 2025
@cjdsellers cjdsellers merged commit a140b5c into develop Sep 24, 2025
17 checks passed
@cjdsellers cjdsellers deleted the ib-fill-report branch September 24, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants