Fix Polymarket ws message handling #2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f59400. More changes are needed that would change these as well.
As a result of this breaking change: https://docs.polymarket.com/developers/CLOB/websocket/market-channel-migration-guide It looks like ws messages only contain single objects as per documentation now as opposed to lists.
Member
|
Hi @thefabus Thanks for the fix and confirming in production 🙏. We'll need to get some more comprehensive automated testing going eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
CONTRIBUTING.mdand followed the established practicesSummary
My last fix #2963 adressed only part of the recent changes and I have reverted it.
Polymarket introduced some breaking changes: https://docs.polymarket.com/developers/CLOB/websocket/market-channel-migration-guide
This PR adresses them and I confirmed that I'm able to receive OrderbookDeltas and Quotes again.
Related Issues/PRs
Type of change
Breaking change details (if applicable)
Documentation
docs/developer_guide/docs.md)Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Ensure new or changed logic is covered by tests.