Add support for data download during backtest#2652
Merged
Conversation
faysou
force-pushed
the
download_data
branch
5 times, most recently
from
94bee45 to
d3ae70b
Compare
|
|
faysou
force-pushed
the
download_data
branch
11 times, most recently
from
2ac3ff8 to
8d5b794
Compare
faysou
force-pushed
the
download_data
branch
8 times, most recently
from
161fd38 to
1e28b9b
Compare
3 tasks
faysou
force-pushed
the
download_data
branch
4 times, most recently
from
d5b6a85 to
6f8617e
Compare
faysou
changed the title
faysou
force-pushed
the
download_data
branch
7 times, most recently
from
be93e2b to
ca3ff99
Compare
cjdsellers
reviewed
Jun 10, 2025
cjdsellers
left a comment
cjdsellers
left a comment
Member
There was a problem hiding this comment.
I still need to wrap my head around the changes to the node, looking great so far though!
cjdsellers
reviewed
Jun 12, 2025
cjdsellers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
Summary
Add download function to backtest node in order to be able to download data and save it to a catalog easily.
This PR builds on previous PRs (see their comments for more details on each of them).
To reduce maintance, I will only rebase this PR while waiting it gets merged.
Related Issues/PRs
#2574
#2594
Type of change
Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Tested on included example