add encode_seed function #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
encode_seed_function
branch
from
482abb3 to
195955f
Compare
olgeni
reviewed
Apr 9, 2024
This function takes a bystring of length 32 and produces an nkey-encoded seed. This function can be used to generate nkeys (with the onus of providing proper entropy left to the user).
JaredCorduan
force-pushed
the
encode_seed_function
branch
from
195955f to
259f17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello again :)
This PR provides the inverse of the existing function
decode_seed, a new function namedencode_seedwhich takes a bytestring of length 32 and produces an nkey-encoded seed.This function can be used to generate nkeys, with the onus of providing proper entropy left to the user. I believe this would resolve #3.
I added a low-tech property test, which checks that encoding followed by decoding is just the identity function. I am a big fan of hypothesis, but I was not sure the appetite here for adding new dependencies.