Skip to content

Add pynacl as a project dependency #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wallyqs merged 1 commit into from
Sep 10, 2024
Merged

Add pynacl as a project dependency #14

wallyqs merged 1 commit into from
Sep 10, 2024

Conversation

@caspervonb
Copy link
Collaborator

@caspervonb caspervonb commented Sep 10, 2024

Fixes #12

@caspervonb
Copy link
Collaborator Author

caspervonb commented Sep 10, 2024 •
edited
Loading

Tested locally with the following Pipfile:

[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
nkeys = {path = "../nkeys.py", editable = true}

[dev-packages]

[requires]
python_version = "3.12"

@caspervonb caspervonb requested review from bruth and wallyqs September 10, 2024 09:41
@caspervonb caspervonb changed the title Add pynacl as a dependency Add pynacl as a project dependency Sep 10, 2024
wallyqs
wallyqs approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit edd5664 into main Sep 10, 2024
@wallyqs wallyqs deleted the fix-pynacl-dependency branch September 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallyqs wallyqs wallyqs approved these changes

@bruth bruth Awaiting requested review from bruth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'nacl'

3 participants

@caspervonb @wallyqs