[FIXED] Some lock inversions #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The established ordering is client -> Account, so fixed few places where we had Account -> client. Added a new file, locksordering.txt with the list of known ordering for some of the objects. Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
force-pushed
the
fix_lock_inversions
branch
from
aebe9b1 to
0fae806
Compare
matthiashanel
approved these changes
Mar 9, 2022
Contributor
matthiashanel
left a comment
matthiashanel
left a comment
There was a problem hiding this comment.
LGTM
I assume the deleted assignments where highlighted by staticcheck or compiler?
Member
Author
Yes, staticcheck, but an updated local version, would not be found on Travis yet since we use their latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The established ordering is client -> Account, so fixed few places
where we had Account -> client.
Added a new file, locksordering.txt with the list of known ordering
for some of the objects.
Signed-off-by: Ivan Kozlovic [email protected]