Skip to content

feat(nack) Add custom labels to ClusterRole or Role #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(nack) Add custom labels to ClusterRole or Role #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e50887
Add custom labels to ClusterRole or Role
rblaine95 Mar 12, 2025
a76f02c
Surround rbac labels with if statement
rblaine95 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/charts/nack/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ keywords:
- nats
- jetstream
- cncf
version: 0.28.0
version: 0.28.1
maintainers:
- email: [email protected]
name: The NATS Authors
Expand Down
6 changes: 5 additions & 1 deletion helm/charts/nack/templates/rbac-jetstream-controller.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ kind: {{ $kind }}
metadata:
name: {{ template "jsc.serviceAccountName" . }}-{{ $kindSuffix }}
namespace: {{ include "jsc.namespace" . }}
{{- if .Values.rbacLabels }}
labels:
{{- tpl (toYaml .Values.rbacLabels) . | nindent 4 }}
{{- end }}
{{ tpl .Values.rbacRules . }}

---
Expand All @@ -28,4 +32,4 @@ subjects:
roleRef:
kind: {{ $kind }}
name: {{ template "jsc.serviceAccountName" . }}-{{ $kindSuffix }}
apiGroup: rbac.authorization.k8s.io
apiGroup: rbac.authorization.k8s.io
3 changes: 3 additions & 0 deletions helm/charts/nack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ additionalVolumes: []
# additionalVolumeMounts are the additional volume mounts to add
additionalVolumeMounts: []

# Custom labels to be added to the ClusterRole or Role
rbacLabels: {}
# rbac.authorization.k8s.io/aggregate-to-admin: "true"
# Rules to be applied to ClusterRole or Role
# Set as a string so that it can be templated to allow further customization
rbacRules: |
Expand Down