lsp-face-highlight-* backgrounds are difficult to distinguish from normal background

[eeshugerman]

Personally, I find these new background colors to be far too similar to the surrounding background. I'm unable pick them out at a glance, which is the point of lsp-enable-symbol-highlighting.

I didn't have this problem before this commit that sets these backgrounds explicitly. Before, I found the colors to be aesthetically pleasing and easily distinguishable.

I suggest choosing different colors, or maybe reverting the change altogether? Barring that, can you tell me how to restore the old behavior in my config? I tried this:

(set-face-background 'lsp-face-highlight-textual nil)
(set-face-background 'lsp-face-highlight-read nil)
(set-face-background 'lsp-face-highlight-write nil)

... but then I get no highlighting at all.

Screenshots:

Thanks!

[nashamri]

Hello @eeshugerman, sorry for the late reply. Yeah these need more work. Meanwhile, you can add this to your use-package to override these 3 faces:

    :custom-face
    (lsp-face-highlight-read ((t (:inherit link :underline t))))
    (lsp-face-highlight-textual ((t (:inherit link))))
    (lsp-face-highlight-write ((t (:inherit link :bold t))))

This is it with my complete use-package config for spacemacs-theme:

  (use-package spacemacs-theme
    :ensure t
    :init (setq spacemacs-theme-comment-bg nil)

    :config
    (setq spacemacs-theme-custom-colors '((bg1 . "#1c1c1f")
                                          (act1 . "#343241")
                                          (highlight . "#2d2c37")
                                          (cblk-ln-bg . "#29252f")
                                          (cblk-bg . "#212024")))

    (load-theme 'spacemacs-dark t)

    :custom-face
    (lsp-face-highlight-read ((t (:inherit link :underline t))))
    (lsp-face-highlight-textual ((t (:inherit link))))
    (lsp-face-highlight-write ((t (:inherit link :bold t)))))

[eeshugerman]

Thanks! That works for now.

For anyone not using use-package, you can apply these like so:

(face-spec-set 'lsp-face-highlight-read '((t (:inherit link :underline t))))
(face-spec-set 'lsp-face-highlight-textual '((t (:inherit link))))
(face-spec-set 'lsp-face-highlight-write '((t (:inherit link :bold t))))