-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Issue 4156 generic hub #4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mshahabn
wants to merge
62
commits into
nasa:devel
Choose a base branch
from
mshahabn:issue-4156-generic-hub
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue 4156 generic hub #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto issue-4156-generic-hub
Use interfaces from Drv
Point FPP to a non-released version with a bug fix
…unit tests (100% test coverage). Added testing documention /test/ut/README.md
Collaborator
|
Thanks, @mshahabn! @LeStarch @thomas-bc Maybe we should defer this PR until after the upcoming release. It contains two components that are still skeletons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added the missing implementation of Generic Hub
Rationale
Fixed implementation TODOs.
Testing/Review Recommendations
Improved test coverage by adding missing port interfaces (100% test coverage)
Future Work
AI Usage (see policy)