Skip to content

Conversation

@Saransh-cpp
Copy link
Contributor

@Saransh-cpp Saransh-cpp commented Oct 30, 2025

Related Issue(s) N/A
Has Unit Tests (y/n) n
Documentation Included (y/n) n
Generative AI was used in this contribution (y/n) n

Change Description

I think the comma was misplaced? I hope I'm not missing anything

@Saransh-cpp Saransh-cpp changed the title fix(.clang-tidy): Checks is supposed to be a comma separated list o… fix(.clang-tidy): Checks is supposed to be a comma separated list Oct 30, 2025
@thomas-bc
Copy link
Collaborator

Some CI failures popping up that seem to suggest these checks weren't actually running with the wrong comma. Thanks! Want to fix the other failure or shall we?

@Saransh-cpp
Copy link
Contributor Author

Thanks for the quick review! I can try fixing those and ask for help here if I struggle :)

@thomas-bc
Copy link
Collaborator

To fix formatting you can use an IDE supporting clang-format or on your branch in fprime: git diff --name-only --relative | fprime-util format --stdin

@Saransh-cpp
Copy link
Contributor Author

Thanks, @thomas-bc!

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for going through these! I'm confused about one of these warnings, but not a blocker in my opinion.

@thomas-bc thomas-bc requested a review from LeStarch November 3, 2025 23:33
@thomas-bc thomas-bc merged commit 903677e into nasa:devel Nov 4, 2025
55 checks passed
@Saransh-cpp Saransh-cpp deleted the patch-1 branch November 4, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants