-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(.clang-tidy): Checks is supposed to be a comma separated list
#4379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checks is supposed to be a comma separated list o…Checks is supposed to be a comma separated list
|
Some CI failures popping up that seem to suggest these checks weren't actually running with the wrong comma. Thanks! Want to fix the other failure or shall we? |
|
Thanks for the quick review! I can try fixing those and ask for help here if I struggle :) |
|
To fix formatting you can use an IDE supporting clang-format or on your branch in fprime: |
|
Thanks, @thomas-bc! |
thomas-bc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for going through these! I'm confused about one of these warnings, but not a blocker in my opinion.
Change Description
I think the comma was misplaced? I hope I'm not missing anything