Skip to content

Conversation

@LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Aug 4, 2025

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Moves telemetry to a rate group call for UART send/receive.

@LeStarch LeStarch requested a review from timcanham August 4, 2025 23:11
@timcanham
Copy link
Collaborator

timcanham commented Aug 4, 2025

I was wondering if we should make this->m_bytesSent and this->m_bytesReceived be std::atomic since multiple threads would access the data. (Hat tip to @bocchino).

@LeStarch
Copy link
Collaborator Author

LeStarch commented Aug 4, 2025

@timcanham agreed.

@timcanham
Copy link
Collaborator

Otherwise, LGTM! Thanks!

@LeStarch
Copy link
Collaborator Author

LeStarch commented Aug 4, 2025

@timcanham want to give the final review? They should be std atomic now.

@LeStarch LeStarch merged commit d460468 into nasa:devel Aug 5, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants