Format Svc and add to CI#3978
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
thomas-bc
commented
Aug 4, 2025
| m_overrunThrottle(0), | ||
| m_cycleSlips(0) {} | ||
|
|
||
| void ActiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) { |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
|
|
||
| DpCatalog ::~DpCatalog() {} | ||
|
|
||
| void DpCatalog::configure(Fw::FileNameString directories[DP_MAX_DIRECTORIES], |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
thomas-bc
marked this pull request as ready for review
August 4, 2025 22:56
LeStarch
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Towards #1984
Format Svc/ module (except FpySequencer which is WIP) and add to CI