Skip to content

Format Drv module #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

Format Drv module #3960

merged 3 commits into from
Jul 31, 2025

Conversation

@thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Jul 31, 2025 •
edited
Loading

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Format Drv/ module and add to CI

In progress of #1984

Review Recommendations

Use this link to not show whitespace diffs https://github.com/nasa/fprime/pull/3960/files?w=1

image

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2025
View reviewed changes
Drv/Ports/DataTypes/DataBuffer.cpp
}
DataBuffer::DataBuffer(const DataBuffer& other) : Fw::SerializeBufferBase() {
Fw::SerializeStatus stat = Fw::SerializeBufferBase::setBuff(other.m_data, other.getBuffLength());
FW_ASSERT(Fw::FW_SERIALIZE_OK == stat, static_cast<FwAssertArgType>(stat));

Check warning

Code scanning / CppCheck

Member variable 'DataBuffer::m_data' is not assigned in the copy constructor. Should it be copied? Warning

Member variable 'DataBuffer::m_data' is not assigned in the copy constructor. Should it be copied?
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2025
View reviewed changes
Drv/Ip/IpSocket.cpp
}

SocketIpStatus IpSocket::configure(const char* const hostname, const U16 port, const U32 timeout_seconds, const U32 timeout_microseconds) {
SocketIpStatus IpSocket::configure(const char* const hostname,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Drv/Ip/IpSocket.hpp
public:
IpSocket();
virtual ~IpSocket(){};
virtual ~IpSocket() {};

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/Ip/SocketComponentHelper.cpp
SocketComponentHelper::~SocketComponentHelper() {}

void SocketComponentHelper::start(const Fw::StringBase &name,
void SocketComponentHelper::start(const Fw::StringBase& name,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Drv/LinuxI2cDriver/LinuxI2cDriver.cpp
// Construction, initialization, and destruction
// ----------------------------------------------------------------------

LinuxI2cDriver ::LinuxI2cDriver(const char* const compName) : LinuxI2cDriverComponentBase(compName), m_fd(-1) {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/LinuxI2cDriver/LinuxI2cDriver.cpp

// Note this port handler is guarded, so we can make the ioctl call

Drv::I2cStatus LinuxI2cDriver ::write_handler(const FwIndexType portNum, U32 addr, Fw::Buffer& serBuffer) {

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Drv/Ports/DataTypes/DataBuffer.cpp

DataBuffer::DataBuffer() {
}
DataBuffer::DataBuffer() {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/Ports/DataTypes/DataBuffer.cpp

DataBuffer::~DataBuffer() {
}
DataBuffer::~DataBuffer() {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/TcpClient/TcpClientComponentImpl.cpp

TcpClientComponentImpl::TcpClientComponentImpl(const char* const compName)
: TcpClientComponentBase(compName) {}
TcpClientComponentImpl::TcpClientComponentImpl(const char* const compName) : TcpClientComponentBase(compName) {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/TcpServer/TcpServerComponentImpl.cpp

TcpServerComponentImpl::TcpServerComponentImpl(const char* const compName)
: TcpServerComponentBase(compName) {}
TcpServerComponentImpl::TcpServerComponentImpl(const char* const compName) : TcpServerComponentBase(compName) {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
Drv/Udp/UdpComponentImpl.cpp

UdpComponentImpl::UdpComponentImpl(const char* const compName)
: UdpComponentBase(compName) {}
UdpComponentImpl::UdpComponentImpl(const char* const compName) : UdpComponentBase(compName) {}

Check notice

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2025
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@LeStarch LeStarch merged commit e17d42a into nasa:devel Jul 31, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomas-bc @LeStarch