Skip to content

Clang 20.1 UT Errors #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 2, 2025
Merged

Clang 20.1 UT Errors #3949

merged 11 commits into from
Aug 2, 2025

Conversation

@m-aleem
Copy link
Contributor

@m-aleem m-aleem commented Jul 29, 2025 •
edited
Loading

Related Issue(s) #3360
Has Unit Tests (y/n) Existing
Documentation Included (y/n) N/A

Change Description

Fix clang-tidy errors when using >= clang-tidy version 18

Rationale

A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.

Testing/Review Recommendations

install updated fpp (from my updated fpp repo corresonding to nasa/fpp#764)

cd $MY_FPP_DIRECTORY && pwd && cd compiler && ./install "$(dirname "$(which fpp-depend)" )"

genreate and build UTs with clang-tidy > 18

>> clang-tidy --version
LLVM (http://llvm.org/):
  LLVM version 20.1.0
  Optimized build.
>> fprime-util generate -f --ut -DCMAKE_CXX_CLANG_TIDY=clang-tidy -DFPRIME_SKIP_TOOLS_VERSION_CHECK=1
>> fprime-util build --all --ut -j16
>> fprime-util check

No failures

>> fprime-util generate -f -DCMAKE_CXX_CLANG_TIDY=clang-tidy -DFPRIME_SKIP_TOOLS_VERSION_CHECK=1 && fprime-util build

Builds fine

Future Work

None

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 29, 2025
View reviewed changes
@m-aleem m-aleem marked this pull request as ready for review July 30, 2025 02:34
thomas-bc
thomas-bc previously approved these changes Jul 30, 2025
View reviewed changes
LeStarch
LeStarch reviewed Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flight code looks good. I agree with @thomas-bc about using STest.

@m-aleem m-aleem requested review from LeStarch and thomas-bc July 30, 2025 21:03
@m-aleem m-aleem marked this pull request as draft July 31, 2025 01:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2025
View reviewed changes
Svc/ActiveTextLogger/ActiveTextLogger.cpp
// Format the string here, so that it is done in the task context
// of the caller. Format doc borrowed from PassiveTextLogger.
const char *severityString = "UNKNOWN";
const char *severityString = nullptr;

Check notice

Code scanning / CodeQL

Use of basic integral type Note

severityString uses the basic integral type char rather than a typedef with size and signedness.
Svc/PassiveConsoleTextLogger/ConsoleTextLoggerImplCommon.cpp

void ConsoleTextLoggerImpl::TextLogger_handler(FwIndexType portNum, FwEventIdType id, Fw::Time &timeTag, const Fw::LogSeverity& severity, Fw::TextLogString &text) {
const char *severityString = "UNKNOWN";
const char *severityString = nullptr;

Check notice

Code scanning / CodeQL

Use of basic integral type Note

severityString uses the basic integral type char rather than a typedef with size and signedness.
@m-aleem m-aleem marked this pull request as ready for review July 31, 2025 17:07
@thomas-bc thomas-bc merged commit 02afd01 into nasa:devel Aug 2, 2025
52 of 53 checks passed
@m-aleem m-aleem deleted the devel-3360 branch August 4, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

@LeStarch LeStarch Awaiting requested review from LeStarch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-aleem @LeStarch @thomas-bc