Skip to content

Conversation

@moisesmata
Copy link
Contributor

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Changed all relevant references to CCSDS to Ccsds throughout the codebase.

Rationale

Follows Pascal Case conventions that are prevalent throughout the codebase.

//! \brief expected flags and spacecraft ID token for a valid CCSDS TC frame
const U16 m_expectedFlagsAndScIdToken =
0x1 << CCSDS::TCSubfields::BypassFlagOffset | (ComCfg::FppConstant_SpacecraftId::SpacecraftId);
0x1 << Ccsds::TCSubfields::BypassFlagOffset | (ComCfg::FppConstant_SpacecraftId::SpacecraftId);

Check notice

Code scanning / CodeQL

Implicit precedence in compound expression Note

This expression involving bitwise operations should be bracketed.
if (data.get_allocated_size() < CCSDS::TCHeader::SERIALIZED_SIZE + CCSDS::TCTrailer::SERIALIZED_SIZE) {
size_out = CCSDS::TCHeader::SERIALIZED_SIZE + CCSDS::TCTrailer::SERIALIZED_SIZE;
if (data.get_allocated_size() < Ccsds::TCHeader::SERIALIZED_SIZE + Ccsds::TCTrailer::SERIALIZED_SIZE) {
size_out = Ccsds::TCHeader::SERIALIZED_SIZE + Ccsds::TCTrailer::SERIALIZED_SIZE;

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter size_out has not been checked.
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@thomas-bc thomas-bc merged commit 679cab7 into nasa:devel Jun 23, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants