Skip to content

Conversation

@moisesmata
Copy link
Contributor


Change Description

  • The fatal handler component has been moved from the Ref topology to the CDHCore subtopology
  • Updated naming for the configuration folder in CDHCore. CDHCoreConfig -> config. The fpp file and its references in CMakeLists have also been changed accordingly. This structure will continue in future subtopologies.
  • add_dependencies in TestDeployment removed, not needed due to recent CMake improvements

@moisesmata moisesmata marked this pull request as ready for review June 17, 2025 21:12
@moisesmata moisesmata requested review from Copilot and thomas-bc June 17, 2025 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the fatal handler component from the Ref topology into the CDHCore subtopology, updates the configuration folder and related file references, and removes an unnecessary dependency from TestDeployment.

  • Moved fatal handler instance and connection from Ref to CDHCore.
  • Renamed the configuration folder from "CDHCoreConfig" to "config" and updated CMakeLists accordingly.
  • Removed add_dependencies(TestDeployment ...) based on recent CMake improvements.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmake/test/data/TestDeployment/CMakeLists.txt Removed obsolete add_dependencies for Svc_Subtopologies_CDHCore.
Svc/Subtopologies/CDHCore/config/config.fpp Added fatalHandler instance with updated configuration and comment note.
Svc/Subtopologies/CDHCore/config/CMakeLists.txt Updated file reference from CDHCoreConfig.fpp to config.fpp.
Svc/Subtopologies/CDHCore/CMakeLists.txt Updated subdirectory reference from CDHCoreConfig to config.
Svc/Subtopologies/CDHCore/CDHCore.fpp Added fatalHandler instance and its connection in the FaultProtection block.
Ref/Top/topology.fpp Removed fatalHandler instance and its connection from the Ref topology.
Ref/Top/instances.fpp Removed fatalHandler instance and modified comDriver’s base id.

@LeStarch LeStarch merged commit da13651 into nasa:devel Jun 18, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants