Skip to content

PRIVATE->private and PROTECTED->protected updates in Svc/FpySequencer #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025
Merged

PRIVATE->private and PROTECTED->protected updates in Svc/FpySequencer #3737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e730d32
PRIVATE->private and PROTECTED->protected updates in Svc/FpySequencer
m-aleem Jun 11, 2025
1f54cf9
Merge branch 'nasa:devel' into devel-3446-f-v2
m-aleem Jun 16, 2025
8a710ec
Clean up new UT public/private helpers
m-aleem Jun 16, 2025
45b663b
sp
LeStarch Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/spelling/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ gcgandhi
gcov
gdiplus
GENHUB
getfooter
getstatements
gettime
getty
ghprb
Expand Down
9 changes: 6 additions & 3 deletions Svc/FpySequencer/FpySequencer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ using Signal = FpySequencer_SequencerStateMachineStateMachineBase::Signal;
using State = FpySequencer_SequencerStateMachineStateMachineBase::State;

class FpySequencer : public FpySequencerComponentBase {

friend class FpySequencerTester;

public:
union DirectiveUnion {
FpySequencer_WaitRelDirective waitRel;
Expand Down Expand Up @@ -66,7 +69,7 @@ class FpySequencer : public FpySequencerComponentBase {
//!
~FpySequencer();

PRIVATE :
private:

//! Handler for command RUN
//!
Expand Down Expand Up @@ -307,7 +310,7 @@ class FpySequencer : public FpySequencerComponentBase {
const Svc::FpySequencer_DebugBreakpointArgs& value //!< The value
) override;

PROTECTED :
protected:

// ----------------------------------------------------------------------
// Functions to implement for internal state machine guards
Expand Down Expand Up @@ -401,7 +404,7 @@ class FpySequencer : public FpySequencerComponentBase {
void allocateBuffer(FwEnumStoreType identifier, Fw::MemAllocator& allocator, FwSizeType bytes);

void deallocateBuffer(Fw::MemAllocator& allocator);
PRIVATE :
private :

static constexpr U32 CRC_INITIAL_VALUE = 0xFFFFFFFFU;

Expand Down
Loading
Loading