Fix directory detection bug in Os::FileSystem::getPathType #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thomas-bc
reviewed
Jun 12, 2025
…:OTHER. Fixing a spelling mistake.
LeStarch
requested changes
Jun 12, 2025
thomas-bc
changed the title
Collaborator
|
Labeling this so we remember to mention the new implementation-specific function in the release notes |
thomas-bc
added
the
Breaking Changes / Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fix directory detection in Os::FileSystem::getPathType. The new code is relying on standard POSIX features
stat(),S_ISDIR, andS_ISREGfor detection instead of trying to open.Rationale
This fixes a bug that incorrectly detects a directory as a regular file.
Testing/Review Recommendations
New UT,
DetectDirectory, added toFileSystemRulesthat test the following cases.Future Work
None