Add Core Subtopologies: CDHCore #3720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
…nfig clarity improvements
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
…ogies, needs cleaning up
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thomas-bc
reviewed
Jun 12, 2025
- Subtopology with core CDH functionality within Svc - integrated within Ref Deployment - PingEntries.hpp within CDHCore/ that provides default values for PingEntries - Default TlmChan, option to use TlmPacketizer through changing CDHCoreConfig.fpp
check-spelling run (pull_request_target) for add-cdhcore-subtopology Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
thomas-bc
changed the title
thomas-bc
requested changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Within fprime/Svc there is now a Subtopologies folder. The folder contains a subtopolgy, CDHCore, which contains 7 Svc components:
The subtopology's header "PingEntries.hpp" also now contains the PingEntries for each of the relevant components. If desired, users may swap this header for another in their deployment to customize values and have one list for all component PingEntries.
Ref has been modified to import and use this CDHCore subtopology within the Ref deployment topology.
Ref integration test has swapped names to refer to CDHCore.cmdDisp and CDHCore.events, instead of Ref.cmdDisp and Ref.eventLogger.
Future Work
3 further subtopologies that contain core flight software stacks (Comms, FileHandling, DataProducts) will be added in future pull requests.