Skip to content

Conversation

@jwest115
Copy link
Collaborator

@jwest115 jwest115 commented Jun 10, 2025

Related Issue(s) #3529
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

  • Added FwIdType alias (default is U32), which represents the max ID type size. Updated PassiveComponentBase to use this type for the base ID.
  • Updated the following types in FpConfig.fpp to be aliases of FwIdType:
    • FwChanIdType
    • FwDpIdType
    • FwEventIdType
    • FwOpcodeType
    • FwPacketDescriptorType
    • FwPrmIdType
  • Updated component FPP so the proper types are used for IDs (example: FwOpcodeType for opcodes instead of U32).
  • Updated related component cpp/hpp so the Fw type is used instead of U32.
  • Updated unit tests so the Fw type is used instead of U32.

Rationale

Needed when changing the Fw types in FwConfig.fpp to something other than U32.

Testing/Review Recommendations

Confirmed fprime builds successfully and without any warnings. Confirmed that all unit tests pass.

Related FPP change is in this PR nasa/fpp#737, should wait until the FPP PR is merged and the FPP version is updated in this PR before merging.

@jwest115 jwest115 marked this pull request as ready for review June 11, 2025 16:57
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what I'd expect!

@LeStarch LeStarch merged commit be91bfa into nasa:devel Jun 16, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants