Skip to content

Conversation

@m-aleem
Copy link
Contributor

@m-aleem m-aleem commented Jun 3, 2025

Related Issue(s) #3446
Has Unit Tests (y/n) Yes - existing
Documentation Included (y/n) N/A

Change Description

Updates to fprime/FppTest/component:

  • PRIVATE -> private

Rationale

#3446

Testing/Review Recommendations

Testing Conducted: I ran the following inside FppTest: fprime-util generate --ut;fprime-util build --ut;fprime-util check and ensured no failures.

@m-aleem m-aleem requested a review from LeStarch June 3, 2025 04:18
@m-aleem
Copy link
Contributor Author

m-aleem commented Jun 3, 2025

UTs passed when I ran locally, but in CI timing test PosixRawTimeTest seems to have failed.

@thomas-bc
Copy link
Collaborator

PosixRawTimeTest will fail very occasionally because of the way the tests are designed. Re-running the CI job usually fixes it.

There's likely a way to improve the UT design so that it should deterministically succeed, but it hasn't been enough of an issue that we would prioritize to improve on it.

@LeStarch LeStarch merged commit 5a0acd1 into nasa:devel Jun 3, 2025
50 of 51 checks passed
@m-aleem m-aleem deleted the devel-3446-l branch June 3, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants