Skip to content

Add support for CCSDS TC/TM and SpacePacket protocols #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 108 commits into from
Jun 11, 2025
Merged

Add support for CCSDS TC/TM and SpacePacket protocols #3684

merged 108 commits into from
Jun 11, 2025

Conversation

@thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Jun 2, 2025

Related Issue(s) #3443
Has Unit Tests (y/n) yes
Documentation Included (y/n) yes

Change Description

Fix #3443 #3491 #3492

Add Framers and Deframers (and helpers) to support encapsulating F´ data in CCSDS Space Packets + TC and TM frames.

Each protocol is supported as described by the component SDD.

Rationale

A long standing request by the community.
#1397 #2507 #3026

Future Work

TBD

thomas-bc and others added 30 commits April 30, 2025 12:14
@thomas-bc
First pass at Svc + TcpClient implementation
7311cbc
@thomas-bc
Tmp work
0ae7ba9
@thomas-bc
Revert FileUplink changes
e60ffad
@thomas-bc
Add copy (with allocation/deallocation) to FprimeRouter to simplify b…
56dc659 
…uffer management
@thomas-bc
Update FprimeRouter UTs
8bc06f3
@thomas-bc
Update FprimeDeframer UTs
0b69b1f
@thomas-bc
Update FrameAccumulator UTs
678fd45
@thomas-bc
Update ComStub UTs
66d5a91
@thomas-bc
Update missing Drv and UTs
6566ae9
@thomas-bc
Update ComInterface to use ComDataWithContext on output
75638b0
@thomas-bc
Update Ref/RPI topology
e2449af
@thomas-bc
Fix spelling
84d5afe
@thomas-bc
Fix test typo
57f4c0f
@thomas-bc
Update Udp component and UTs
db4d33c
@thomas-bc
Rename data ports and standardize "Return" naming pattern
52dc98d
@thomas-bc
Merge branch 'devel' into uplink-buffer-return
a507cdf
@thomas-bc
Fix variable name
2040518
@thomas-bc
Adapt UTs
1490693
@thomas-bc
Update Communication Adapter Interface docs
99c2b75
@thomas-bc
Full SDD updates
58dab50
@thomas-bc
Spelling & nits and details
d3d7857
@thomas-bc
Put formatting back to original
c205399
@thomas-bc
Merge branch 'uplink-buffer-return' into ccsds-protocols
fcd852a
@thomas-bc
Added SpacePacket, TC and TM framers/deframers + Ref topology. Workin…
4ca0304 
…g with GDS wohooo
@thomas-bc
TODOs and code cleanup
4c4c24a
@thomas-bc
Add APID enum to ComCfg.fpp and route based on received APID
1f1e456
@thomas-bc
Merge remote-tracking branch 'nasa/devel' into ccsds-protocols
0eb242a
@thomas-bc
Increment counts per frame/apid
d65e591
@thomas-bc
Remove duplicate files
9214221
@thomas-bc
Document and implement services/functions provided by the TCDeframer
6282625
@thomas-bc thomas-bc requested review from LeStarch and Copilot June 7, 2025 01:35

This comment was marked as resolved.

Sign in to view

@thomas-bc thomas-bc mentioned this pull request Jun 10, 2025
Merged
thomas-bc
thomas-bc commented Jun 11, 2025
View reviewed changes
LeStarch
LeStarch previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some annotations, but otherwise looks good!

@LeStarch LeStarch merged commit 728a022 into nasa:devel Jun 11, 2025
68 of 69 checks passed
@thomas-bc thomas-bc deleted the ccsds-protocols branch June 11, 2025 18:04
celskeggs
celskeggs reviewed Jun 11, 2025
View reviewed changes
thomas-bc added a commit that referenced this pull request Jun 12, 2025
@thomas-bc
Fix miscellaneous items following #3684 CCSDS (#3726)
14bac5f 
* De-conflict Ref instance IDs

* Assert Space Packet data length at least 1

* Fix TcDeframer SDD
@thomas-bc thomas-bc added the Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates. label Aug 6, 2025
@thomas-bc
Copy link
Collaborator Author

thomas-bc commented Aug 7, 2025 •
edited
Loading

Significant Features

  • F Prime now supports the CCSDS TC, TM, and SpacePacket protocols through a set of Framers and Deframers. New deployments are now created with the CCSDS protocol stack by default, and the F´ GDS has also been switched to use CCSDS by default. Users that wish to use the F´ GDS with the F Prime protocol should use fprime-gds --framing-selection fprime
  • The Uplink and Downlink stack have been upgraded to be more easily customizable by users. Usage of this new comms stack is demonstrated in the Svc.ComFprime subtopology for the F Prime framing protocol (default pre-v4.0 setup) and Svc.ComCcsds for the CCSDS protocols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@LeStarch LeStarch LeStarch approved these changes

+1 more reviewer

@celskeggs celskeggs celskeggs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert F Prime frames to use CCSDS

3 participants

@thomas-bc @LeStarch @celskeggs