Update mutex and condition-variable interface #3158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeStarch
requested changes
Jan 27, 2025
LeStarch
approved these changes
Jan 27, 2025
LeStarch
added
the
Breaking Changes / Needs Release Notes
Collaborator
Update Instructions SynopsisWe need to write-up instructions for OS implementers that the ConditionVariable API has changed to return a status. Users should know that they must hold the lock to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Updated ConditionVariable wait API to pend with a return status.
Rationale
Originally, the F Prime ConditionVariable wait function was locking the mutex. This led to double locking the mutex because the underlying OS' ConditionalVariable wait library call was also locking the mutex. This is an issue because we only do a single unlock.
Testing/Review Recommendations
Run UTs, run CI and nominal FIT tests.
Future Work