Skip to content

Stop ignoring real buffers shrunk to 0 size #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Stop ignoring real buffers shrunk to 0 size #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c5016
Stop ignoring real buffers shrunk to 0 size
celskeggs Jan 23, 2025
81bf5d5
Rename ZeroSizeBuffer to NullEmptyBuffer
celskeggs Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Svc/BufferManager/BufferManagerComponentImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,12 @@ namespace Svc {
// make sure component has been set up
FW_ASSERT(this->m_setup);
FW_ASSERT(m_buffers);
// check for empty buffers - this is just a warning since this component returns
// empty buffers if it can't allocate one.
if (fwBuffer.getSize() == 0) {
this->log_WARNING_HI_ZeroSizeBuffer();
// check for null, empty buffers - this is a warning because this component returns
// null, empty buffers if it can't allocate one.
// however, empty non-null buffers could potentially be previously allocated
// buffers with their size reduced. the user is allowed to make buffers smaller.
if (fwBuffer.getData() == nullptr && fwBuffer.getSize() == 0) {
this->log_WARNING_HI_NullEmptyBuffer();
this->m_emptyBuffs++;
return;
}
Expand Down
6 changes: 3 additions & 3 deletions Svc/BufferManager/Events.fppi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ event NoBuffsAvailable(
format "No available buffers of size {}" \
throttle 10

@ The buffer manager received a zero-sized buffer as a return. Probably undetected empty buffer allocation
event ZeroSizeBuffer \
@ The buffer manager received a null pointer and zero-sized buffer as a return. Probably undetected failed buffer allocation
event NullEmptyBuffer \
severity warning high \
id 0x01 \
format "Received zero size buffer" \
format "Received null pointer and zero size buffer" \
throttle 10
Loading