Fix format string specifiers for queue and task names #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Replace format string specifier
%dwith%PRI_FwSizeTypewhere it is used forFwSizeTypevalues. This is needed in two cases gated behindFW_OBJECT_NAMES == 0.Rationale
The
%dspecifier forFwSizeTypevalues does not work on platforms whereFwSizeTypeis 64 bits. The replacement works correctly on all platforms. It appears that this was missed due to a lack of validation ofFW_OBJECT_NAMES == 0code, or perhaps a lack of-Werrorin the native toolchain.Testing/Review Recommendations
N/A
Future Work
Implementing #3100 might help catch these kinds of bugs sooner.