Fix LinuxGpioDriver build w/ disabled object names #3103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When F Prime is configured with FW_OBJECT_NAMES == 0, the getObjName() function is not available, which causes a failure to build.
LeStarch
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When F Prime is configured with FW_OBJECT_NAMES == 0, the getObjName() function is not available, which causes a failure to build. Use FW_OPTIONAL_NAME to allow LinuxGpioDriver to build.
Rationale
Allows projects that set FW_OBJECT_NAMES to 0 to run
fprime-util build nativeon their root directory without issue.Testing/Review Recommendations
There's an argument for using a better replacement than an empty string when object names are omitted, but I'm not sure it matters very much.
Future Work
It would be nice to have a Linux platform with FW_OBJECT_NAMES == 0 be included in CI to avoid problems like this from cropping up in the future.