Allow array types and values of arbitrary size

compiler/lib/src/main/scala/analysis/Analysis.scala

@@ -352,24 +352,12 @@ case class Analysis(
   def getNonnegativeIntValueOpt[T](nodeOpt: Option[AstNode[T]]): Result.Result[Option[Int]] =
     Result.mapOpt(nodeOpt, (node: AstNode[T]) => getNonnegativeIntValue(node.id))
 
-  /** Gets a bounded array size from an AST node */
-  def getBoundedArraySize(id: AstNode.Id): Result.Result[Int] =
-    for {
-      v <- getIntValue(id)
-      size <- if (v >= 1 && v <= Error.maxArraySize)
-        Right(v.intValue) else {
-          val loc = Locations.get(id)
-          Left(SemanticError.InvalidArraySize(loc, v))
-        }
-    }
-    yield size
-
-  /** Gets an optional unbounded array size */
-  def getUnboundedArraySizeOpt[T](nodeOpt: Option[AstNode[T]]): Result.Result[Option[Int]] =
-    Result.mapOpt(nodeOpt, (node: AstNode[T]) => getUnboundedArraySize(node.id))
+  /** Gets an optional array size */
+  def getArraySizeOpt[T](nodeOpt: Option[AstNode[T]]): Result.Result[Option[Int]] =
+    Result.mapOpt(nodeOpt, (node: AstNode[T]) => getArraySize(node.id))
 
-  /** Gets an unbounded array size from an AST node */
-  def getUnboundedArraySize(id: AstNode.Id): Result.Result[Int] =
+  /** Gets an array size from an AST node */
+  def getArraySize(id: AstNode.Id): Result.Result[Int] =
     for {
       v <- getIntValue(id)
       size <- if (v >= 1)

compiler/lib/src/main/scala/analysis/CheckSemantics/FinalizeTypeDefs.scala

@@ -46,7 +46,7 @@ object FinalizeTypeDefs
         // Visit the element type of A, to update its members
         eltType <- TypeVisitor.ty(a, arrayType.anonArray.eltType)
         // Update the size and element type in A
-        size <- a.getBoundedArraySize(data.size.id)
+        size <- a.getArraySize(data.size.id)
         arrayType <- {
           val anonArray = Type.AnonArray(Some(size.toInt), eltType)
           Right(arrayType.copy(anonArray = anonArray))
@@ -137,7 +137,7 @@ object FinalizeTypeDefs
         // Compute the sizes
         sizes <- {
           def mapping(member: Ast.StructTypeMember) = for {
-            intOpt <- a.getUnboundedArraySizeOpt(member.size)
+            intOpt <- a.getArraySizeOpt(member.size)
           } yield (intOpt.map(n => (member.name, n)))
           for (pairs <- Result.map(members, mapping)) yield {
             pairs.filter(_.isDefined).map(_.get).toMap

compiler/lib/src/main/scala/analysis/Semantics/PortInstance.scala

@@ -364,7 +364,7 @@ object PortInstance {
   private def getArraySize(a: Analysis, sizeOpt: Option[AstNode[Ast.Expr]]):
     Result.Result[Int] =
       sizeOpt match {
-        case Some(size) => a.getUnboundedArraySize(size.id)
+        case Some(size) => a.getArraySize(size.id)
         case None => Right(1)
       }