Use topology qualified name for directory names #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove machinery for checking duplicate names They cannot occur
bocchino
approved these changes
Jul 22, 2025
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks great, thanks! I removed the error-checking machinery that's no longer used as a result of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fpp-to-layoutto use the qualified name of the topology when creating directories for storing layout txt files.Tested with Ref deployment and verified visualizer tool runs successfully:
Ref topology
Subtopologies with same topology name
