Skip to content

Run CI on all non-draft PRs #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

Run CI on all non-draft PRs #757

merged 4 commits into from
Jul 9, 2025

Conversation

@Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented Jul 8, 2025

Closes #731

@Kronos3 Kronos3 marked this pull request as draft July 8, 2025 17:36
@Kronos3 Kronos3 marked this pull request as ready for review July 8, 2025 17:37
@Kronos3
Copy link
Collaborator Author

Kronos3 commented Jul 8, 2025

@bocchino I just tested the CI through this PR and I think it has the behavior we want. Here was my procedure:

  1. Opened full PR, CI was triggered normally
  2. Pushed a change, CI was triggered normally
  3. Converted the PR to draft
  4. Pushed a change, CI was skipped
  5. Converted the PR back to full, the change from 4 is automatically CI-ed.

@Kronos3 Kronos3 requested a review from bocchino July 8, 2025 19:45
bocchino
bocchino approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 9df2737 into main Jul 9, 2025
14 checks passed
@bocchino bocchino deleted the ci-non-draft branch July 9, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bocchino bocchino bocchino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run CI on all PRs

3 participants

@Kronos3 @bocchino