Skip to content

Conversation

@bocchino
Copy link
Collaborator

@bocchino bocchino commented Jun 12, 2025

This PR revises the way that framework types are checked and the way that implied uses of framework types are discovered and enforced. The old way was ad-hoc and not quite right. The new way is more systematic and is properly integrated with the rest of the spec and implementation.

  1. Update the spec
  2. Update the algorithms and data structures on the wiki
  3. Revise the algorithm implementations
  4. Add and revise unit tests

Closes #738.

Review

@LeStarch Can you take a look at the specification of the framework definitions in the spec?

Future Work

There are more framework definitions to add (enum types, constant defs). We can add those when we complete #729. We can follow the pattern established here.

@bocchino bocchino marked this pull request as ready for review June 12, 2025 20:16
@bocchino bocchino requested review from LeStarch and jwest115 June 12, 2025 20:16
Copy link
Collaborator

@jwest115 jwest115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question but looks good! Thank you!

Base automatically changed from feature/interfaces to main June 16, 2025 22:29
@bocchino bocchino merged commit 4823b55 into main Jun 17, 2025
14 checks passed
@bocchino bocchino deleted the issue-738-implied-uses branch June 17, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't bypass the UseAnalyzer when checking implied uses in topologies

3 participants