Rework struct toString() #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code cleans up the
toString()on structs which as a side benefit reduces the stack memory required to format the struct into a string (Closes #722).Before
Format each individual member into it's own string on the stack and then use a big old
Fw::String.format()call with a predefined format string to glob all the members into a single string.Now
Move through each member in the string and append the formatted member to the string. There is optionally a single
Fw::String tmpwhich members will use to format into if needed before appending to the output.check-cpp