Skip to content

Conversation

@Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented May 14, 2025

Implements the semantics of FPP Interfaces

  • I pulled out common port maps/checking interface GenericPortInterface so that Interface and Component would not have duplicated code.
  • I had to rework the C++ header computation a bit since interfaces are not a code-generated symbol like our other symbols. Rather they are compile-time only and refer to other symbols.

Closes #699

@Kronos3 Kronos3 force-pushed the interface-semantics branch from 6db2b1b to b81a925 Compare May 14, 2025 18:02
@bocchino bocchino self-requested a review May 20, 2025 01:01
@Kronos3
Copy link
Collaborator Author

Kronos3 commented May 28, 2025

@bocchino I've gone through https://github.com/nasa/fpp/wiki/Adding-New-Features-to-FPP#tools and updated tests accordingly. I'm not quite sure about the changes to the fpp-to-json outputs since there is a new field that is added to import.

Is there a JSON schema I need to update for the fpp-to-json output or is that just for the dictionary?

@bocchino bocchino changed the base branch from interfaces-syntax to feature/interfaces June 3, 2025 16:57
@bocchino bocchino changed the title Interface Semantics Interface semantics Jun 3, 2025
@Kronos3 Kronos3 requested a review from bocchino June 4, 2025 17:08
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino
Copy link
Collaborator

bocchino commented Jun 5, 2025

Is there a JSON schema I need to update for the fpp-to-json output or is that just for the dictionary?

There is no schema for the fpp-to-json output. Most of it is auto-generated by circe.

@bocchino bocchino merged commit a7fbf60 into feature/interfaces Jun 6, 2025
22 of 28 checks passed
@bocchino bocchino deleted the interface-semantics branch June 6, 2025 16:59
@bocchino bocchino mentioned this pull request Jun 6, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants