-
Notifications
You must be signed in to change notification settings - Fork 46
Interface semantics #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface semantics #709
Conversation
6db2b1b to
b81a925
Compare
|
@bocchino I've gone through https://github.com/nasa/fpp/wiki/Adding-New-Features-to-FPP#tools and updated tests accordingly. I'm not quite sure about the changes to the fpp-to-json outputs since there is a new field that is added to import. Is there a JSON schema I need to update for the |
compiler/lib/src/main/scala/analysis/CheckSemantics/CheckUseDefCycles.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/CppWriterState.scala
Outdated
Show resolved
Hide resolved
bocchino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There is no schema for the fpp-to-json output. Most of it is auto-generated by circe. |
Implements the semantics of FPP Interfaces
Closes #699