Skip to content

Conversation

@Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented May 14, 2025

Implements the syntax for interfaces.

Generalized the SpecTopImport AST Node type into a SpecImport so that we could reuse the same grammar rule in both types of imports. The nodes themselves are still different in the final AST so that visitors don't need additional context.

Closes #698

@Kronos3 Kronos3 changed the base branch from main to interfaces May 14, 2025 17:55
@Kronos3 Kronos3 changed the title Implement interfaces syntax Interfaces syntax May 14, 2025
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Before we merge this, can you please complete the process listed here:

https://github.com/nasa/fpp/wiki/Adding-New-Features-to-FPP#implementing-and-testing-new-syntax

Specifically:

  1. Update the AST writer
  2. Update the FPP writer
  3. Add unit tests for fpp-syntax
  4. Add unit tests for fpp-format

@Kronos3 Kronos3 requested a review from bocchino May 28, 2025 17:28
@bocchino bocchino changed the base branch from interfaces to feature/interfaces June 3, 2025 16:55
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 911cffc into feature/interfaces Jun 3, 2025
14 checks passed
@bocchino bocchino deleted the interfaces-syntax branch June 3, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement and test syntax for port interfaces

3 participants