Fix regression in fpp-filenames and fpp-depend #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocchino
changed the title
bocchino
changed the title
Kronos3
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine whether
.hfiles are generated,fpp-filenamesandfpp-dependare computing type information that assumes a complete model. However, these tools have to run on incomplete models. In particular, the generate step now fails in the F Prime build.To fix this issue, I reverted the computation of type info in
ComputeGeneratedFiles.scala, and I took out the code that determines whether an.hfile is generated. We now just report the.hppfiles that are generated, not the.hfiles, if any. This should be good enough for communicating info to the build.