Skip to content

Improve quality of generated C++ #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 25, 2025
Merged

Improve quality of generated C++ #624

merged 15 commits into from
Feb 25, 2025

Conversation

@bocchino
Copy link
Collaborator

@bocchino bocchino commented Feb 20, 2025 •
edited
Loading

  • Add casts to avoid double promotion warnings
  • In unit test code
    • Rename variables to avoid shadowing
    • Add casts to avoid conversion warnings
  • Update the fpp-to-cpp compilation tests to enable these warnings
  • Update the User's Guide to state the gcc/clang flags that are supported

Closes #621.

@bocchino bocchino requested review from Kronos3 and jwest115 February 20, 2025 16:15
@bocchino bocchino merged commit 559597d into main Feb 25, 2025
11 checks passed
@bocchino bocchino deleted the issue-621-double-promotion branch February 25, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwest115 jwest115 jwest115 approved these changes

@Kronos3 Kronos3 Awaiting requested review from Kronos3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make generated C++ comply with -Wdouble-promotion

3 participants

@bocchino @jwest115