Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes iTerm color palettes with upstream by running the tools/update_iterm_palettes.R script. The update adds 8 new color palettes to the ggsci package, making them available through iterm_palettes(), pal_iterm(), scale_color_iterm(), and scale_fill_iterm() functions.
Key Changes:
- Added 8 new iTerm color palettes: branch, No Clown Fiesta (2 variations), novmbr, One Dark Two, owl, traffic, and urban
- Each palette includes both "normal" and "bright" color variants with 6 colors each (Blue, Yellow, Red, Cyan, Green, Magenta)
- Incidental code formatting improvements to several function definitions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/palettes-iterm.R | Added 8 new palette names to iterm_palettes() function and corresponding color definitions for each palette's normal and bright variants |
| R/discrete-cosmic.R | Reformatted function parameter layout for pal_cosmic(), scale_color_cosmic(), and scale_fill_cosmic() |
| R/continuous-tw3.R | Reformatted function parameter layout for rgb_tw3(), pal_tw3(), scale_color_tw3(), and scale_fill_tw3() |
| R/continuous-material.R | Reformatted function parameter layout for rgb_material(), pal_material(), scale_color_material(), and scale_fill_material() |
| R/continuous-bs5.R | Reformatted function parameter layout for rgb_bs5(), pal_bs5(), scale_color_bs5(), and scale_fill_bs5() |
| NEWS.md | Added version 4.2.0 release notes documenting the addition of 8 new iTerm palettes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs
tools/update_iterm_palettes.Rto sync the iTerm palettes with upstream.New palettes added for
iterm_palettes()(and thuspal_iterm(),scale_color_iterm(),scale_fill_iterm()):