Drop usage of set_num_workers in the workflow#194
Open
jakirkham wants to merge 1 commit intonanshe-org:masterfrom
Open
Drop usage of set_num_workers in the workflow#194jakirkham wants to merge 1 commit intonanshe-org:masterfrom
set_num_workers in the workflow#194jakirkham wants to merge 1 commit intonanshe-org:masterfrom
Conversation
We no longer have a `CORES` environment variable that we need to set so one of `set_num_workers` use cases is unneeded. Further following the user's specifications on the number of workers to user is more straightforward now. In other words, we don't need to factor in a scheduler process. Given these changes just use `psutil`'s `cpu_count` directly in the workflow if `num_workers` is not provided. This doesn't handle the `-1` case. However it isn't that big of a deal for the user to adapt as this is user facing code that is deployed with the user for analysis.
Member
Author
|
One thing to keep in mind here is this eliminates the option for the user to specify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer have a
CORESenvironment variable that we need to set so one ofset_num_workersuse cases is unneeded. Further following the user's specifications on the number of workers to user is more straightforward now. In other words, we don't need to factor in a scheduler process. Given these changes just usepsutil'scpu_countdirectly in the workflow ifnum_workersis not provided. This doesn't handle the-1case. However it isn't that big of a deal for the user to adapt as this is user facing code that is deployed with the user for analysis.