Update libcoap to 4.3.5, bump dependencies, improve linking (incl. ESP32)#15
Merged
pulsastrix merged 12 commits intomainfrom Jul 2, 2024
Merged
Update libcoap to 4.3.5, bump dependencies, improve linking (incl. ESP32)#15pulsastrix merged 12 commits intomainfrom
pulsastrix merged 12 commits intomainfrom
Conversation
Code Coverage ReportGenerated for commit d1ab040 on Tue Jul 2 13:31:37 UTC 2024.
|
pulsastrix
force-pushed
the
add_vendored_features_for_dtls
branch
2 times, most recently
from
3a4b561 to
b6d57b4
Compare
pulsastrix
changed the title
pulsastrix
changed the title
Member
Author
|
This PR should now be ready for a review. Implementing the newly added features (OSCORE, WebSockets, fixing DTLS on the threadsafe version of libcoap...) is probably better done in a separate PR, in order to not make this one too big. |
JKRhb
approved these changes
Jul 2, 2024
Member
JKRhb
left a comment
JKRhb
left a comment
There was a problem hiding this comment.
Just found a couple of nits below, otherwise: Looks good to me :)
JKRhb
reviewed
Jul 2, 2024
pulsastrix
added a commit
that referenced
this pull request
Jul 2, 2024
Co-authored-by: Jan Romann <[email protected]>
pulsastrix
added a commit
that referenced
this pull request
Jul 2, 2024
pulsastrix
added a commit
that referenced
this pull request
Jul 2, 2024
JKRhb
approved these changes
Jul 2, 2024
Member
JKRhb
left a comment
JKRhb
left a comment
There was a problem hiding this comment.
See three last nits below, otherwise: LGTM! ;)
pulsastrix
added a commit
that referenced
this pull request
Jul 2, 2024
…DTLS - using mbedtls or tinydtls will no longer force usage of the vendored library version of mbedtls-sys-auto/tinydtls-sys by default - remove dependency on gnutls-sys crate as it is unmaintained, we now handle linking to gnutls ourselves - mbedtls-sys-auto is only used if mbedtls should be vendored, as the crate doesn't allow for disabling vendoring independently and doesn't support mbedtls >= 3.0.0 (see fortanix/rust-mbedtls#320) - in order to use the vendored versions of DTLS crate, you now have to enable the `dtls_backend_[BACKEND]_vendored` feature of libcoap-sys (or the `dtls_[BACKEND]_vendored` feature of libcoap-rs)
Before libcoap 4.3.5, coap_send_rst was inlined, which is why we had to reimplement it, as bindgen didn't generate bindings for it.
Co-authored-by: Jan Romann <[email protected]>
pulsastrix
force-pushed
the
add_vendored_features_for_dtls
branch
from
81f588b to
5b47b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates libcoap to 4.3.5-rc2 as well as some dependencies to the latest released version (some of them had cargo audit warnings).
Also improves some of the linking behavior and adds additional features for DTLS library vendoring
NOTE: libcoap 4.3.5 is not released yet, so we should not release a new version of libcoap to crates.io yet. However, libcoap 4.3.5 fixed some mbedtls linking issues, so i'd like to wait for that instead of switching to 4.3.4a.