Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Dec 23, 2022

closes #959

depends on #926 for storage keys macro, #966 for avoiding lifetime issues and #962 for tx fees

first commit from this PR: f7b6378

This is a breaking change for client - to be able to withdraw from token, client must request PoW challenge from the faucet, solve it and submit tx_testnet_faucet_transfer.wasm tx instead of tx_transfer.wasm.

This is non-breaking change for genesis as the added faucet_pow_difficulty is optional (defaults to 0 - no challenge).

TODOs:

  • integrate in vp_faucet
  • initialize faucet account with difficulty if used in init_chain.rs
  • set faucet_pow_difficulty from genesis
  • add a tx_faucet_transfer wasm to send token::Transfer wrapped in faucet::Solution and increment counter
  • add RPC endpoint to obtain faucet challenge for a token::Transfer
  • integrate in the client transfer command (detect faucet source)
  • allow to configure faucet withdrawal limit from genesis
  • add the PoW into the wrapper tx (with conditional compilation when not(mainnet) to allow fee-less tx (with minimum tx fees from Testnet fees #962)

tzemanovic added a commit that referenced this pull request Dec 26, 2022
@tzemanovic tzemanovic marked this pull request as ready for review December 26, 2022 15:12
@tzemanovic tzemanovic added the breaking:client Namada client breaking change label Dec 26, 2022
@tzemanovic tzemanovic requested a review from juped December 26, 2022 15:20
@tzemanovic tzemanovic mentioned this pull request Dec 28, 2022
* origin/tomas/gats-lifetimes-refactor:
  [ci] wasm checksums update
  core/storage: remove redundant `StorageWrite` impl for mut ref
  changelog: #966
  core/storage_api: use GATs to hide lifetime in StorageRead trait
  core/storage/mockDB: remove unused `reverse_order` flag
  [ci] wasm checksums update
  changelog: add #912
  wasm_for_tests: make
  storage: remove rev_iter_prefix, which doesn't work as expected
  test in apps/ledger/storage: test prefix iterators
@tzemanovic tzemanovic marked this pull request as draft December 28, 2022 10:49
tzemanovic added a commit that referenced this pull request Dec 28, 2022
@tzemanovic tzemanovic marked this pull request as ready for review December 28, 2022 13:25
@tzemanovic tzemanovic marked this pull request as draft December 28, 2022 13:27
tzemanovic added a commit that referenced this pull request Dec 28, 2022
@tzemanovic
Copy link
Collaborator Author

pls update wasm

@tzemanovic tzemanovic marked this pull request as ready for review December 28, 2022 15:08
* origin/grarco/basic-fee:
  changelog: add #962
  Fixes unit tests
  Fixes process proposal fee token
  Fixes fee value in tx contruction
  Adds fee burning and checks
  changed to 0.12.2
  Namada 0.12.2
  release: cherry-pick release improvements
  changelog: add #952
  prepare_proposal: update comment to reflect hotfix
  prepare_proposal: use TxRecord struct on ABCI++ build
  missed a chain-id addition
  Prioritize wrapper txs during proposal construction
  Hot fix PrepareProposal
  added chain id and fixed install docs
  update pseudocode
  General housekeeping
  Reward distribution: general improvements
  Cubic slashing: general writing improvements
  Cubic slashing: add new improved pseudocode blurb (Rust-style)
  Cubic slashing: clarify slash iteration procedure and equation
  Cubic slashing: fix and improve plot
  quick fix to cubic slash
  changelog: add #911
  changelog: add #876
  test/core: run less cases on `update_epoch_after_its_duration` test
  changelog: add #945
  ci: install cargo-about on release step
  make-package.sh: include license information in tarball
  release: add configuration for cargo-about
  changelog: add #943
  make-package.sh: don't attempt to include matchmaker
  Namada 0.12.1
  changelog: add #942
  vp_verify_masp: avoid panicking unwrap()s
  changed the docker link (again)
  Changed the first header of pages to H1 in 2 occasions in Namada Specs
  Replaced non-breaking space with space to fix faulty formatting
  fix transfer args
@tzemanovic tzemanovic marked this pull request as draft December 28, 2022 17:16
@tzemanovic tzemanovic mentioned this pull request Dec 30, 2022
@tzemanovic
Copy link
Collaborator Author

closing in favor of #969

@tzemanovic tzemanovic closed this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:client Namada client breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement PoW based faucet

7 participants