Plug BlockSpaceAllocator logic into ProcessProposal
#895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
approved these changes
Dec 16, 2022
Comment on lines
+128
to
+129
| AllocationError = 8, /* NOTE: keep these values in sync with | ||
| * [`ErrorCodes::is_recoverable`] */ |
Contributor
There was a problem hiding this comment.
ErrorCodes::is_recoverable should be matching on this enum rather than returning (self as u32) <= 3, to enforce this (related to this NOTE but not the PR itself though, we shouldn't change this as part of this PR)
Collaborator
Author
There was a problem hiding this comment.
that's how it was defined in ProcessProposal before, this is_recoverable() method came from a ProcessProposal refactor from back when I was working on eth events vote extensions
…/ethbridge/process-proposal-allocator
sug0
changed the title
ProcessProposalBlockSpaceAllocator logic into ProcessProposal
batconjurer
requested changes
Dec 19, 2022
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
nit: Can the tx building fns in prepare proposal be defined in the same order they are used in the main method?
batconjurer
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #897
Adds some validation of the
BlockSpaceAllocatorlogic intoProcessProposal.SPECS: https://hackmd.io/unZg8ia4SZCKDQIY-s8d_Q?view=